This repository has been archived by the owner on Nov 3, 2023. It is now read-only.
Refactor analysis for per turn eval #3780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mus1cholic
requested review from
jaseweston,
ylannb,
stephenroller and
EricMichaelSmith
| @@ -253,6 +251,11 @@ def __init__( | |||
| } | |||
| ) | |||
|
|
|||
| def process_left_pane_text(self, args: "DictConfig") -> str: | |||
There was a problem hiding this comment.
hmm, honestly, I think that these 3 lines of code will probably be the same for all subclasses of model_chat, meaning that the lines will need to get repeated in all subclasses. I think it'll lead to less duplicated code if, instead, there's a method called something like format_left_pane_text(), which you just define as pass for this superclass
parlai/crowdsourcing/tasks/model_chat/task_config/model_opts.yaml
Outdated
Show resolved
Hide resolved
| @@ -1,2 +1,3 @@ | |||
| blender_90M: > | |||
| --model-file zoo:blender/blender_90M/model | |||
|
|
|||
stephenroller
approved these changes
Jul 12, 2021
EricMichaelSmith
approved these changes
Jul 15, 2021
|
CI tests passed, merging in now |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch description
Refactors code for processing left_pane_text so code injections can be made on other crowdsourcing tasks
Testing steps
See CircleCI tests