This repository was archived by the owner on Nov 3, 2023. It is now read-only.
[RAG] Handle nan scores.
#3818
Merged
[RAG] Handle nan scores.
#3818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| '\n[ Document scores are NaN; please look into the built index. ]\n' | ||
| '[ If using a compressed index, try building an exact index: ]\n' | ||
| '[ $ python index_dense_embeddings --indexer-type exact... ]' | ||
| ) |
There was a problem hiding this comment.
Should the error message also mention something about replacing some dummy numbers for score?
There was a problem hiding this comment.
don't think it's necessary
mojtaba-komeili
approved these changes
Jul 19, 2021
spencerp
reviewed
Jul 20, 2021
| '[ If using a compressed index, try building an exact index: ]\n' | ||
| '[ $ python index_dense_embeddings --indexer-type exact... ]' | ||
| ) | ||
| scores.fill_(1) |
There was a problem hiding this comment.
I'm curious why 1 is the error value?
There was a problem hiding this comment.
i picked an arbitrary number so that the scores play nicely with the rest of the system
the scores are literally a tensor of nans:
ipdb> scores
tensor([[nan, nan, nan, nan, nan]], device='cuda:0', dtype=torch.float16)
so needed to pick something that worked
|
I'm pretty sure the failing tests are unrelated to this PR; they are currently being hammered out elsewhere, so will merge as is |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch description
Handles a bug caught in #3806; if the index building goes wrong, there's a possibility that the context/document scores are nan's; this seems to occur if there's an issue with the clustering of the vectors (see linked FAISS issue in #3806)
Testing steps
Reproduced the error with steps in #3806; verified that, with this fix, the error is no longer an issue.