This repository has been archived by the owner on Nov 3, 2023. It is now read-only.
Wizard of Wikipedia, knowledge source page title. #3845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klshuster
approved these changes
Jul 22, 2021
| '--conversation-history-length', | ||
| type=int, | ||
| default=0, | ||
| help='Number of previous utterances to keep in context, 0 (default) includes all', |
There was a problem hiding this comment.
can we make the default -1? and have that map to including all? making 0 mean includes all doesn't seem right (as one could argue this should include... none)
There was a problem hiding this comment.
I changed default to -1, and added something to change any non-positive value to that.
| type='bool', | ||
| default=False, | ||
| help=( | ||
| 'Whether to skip the example if no passage was selected. If `false` ' |
There was a problem hiding this comment.
i wonder if this teacher would be more useful with this flag default to True, since we really want to train a model that can generate titles (not just generate TOKEN_NOCHOSEN). Anyway that's up to you
There was a problem hiding this comment.
I agree, that might make more sense.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch description
Added
WikiPageTitleTeacherto the Wizard of Internet task. It generates the title of the Wikipedia page of the passage that Wizard selected as their source of knowledge, orno_passages_usedif there was no selection.Testing steps
TestWikiPageTitleTeacherto teacher tests.