This repository has been archived by the owner on Nov 3, 2023. It is now read-only.
AcceptabilityChecker min words adjustable #3846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Yeah, very useful to have! Small nit though: I think it'd be better as a class attribute (i.e. like ALL_VIOLATION_TYPES), because it's only used in the context of AcceptabilityChecker. You could do something like self.min_words_violation_threshold = min_words or self.DEFAULT_MIN_WORDS_THRESHOLD
EricMichaelSmith
approved these changes
Jul 23, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch description
The minimum number of words for
AcceptabilityCheckeris a hard-coded value (3). Needless to say this value may not work in all scenarios. This is a quick patch allowing user to adjust the minimum acceptable number of words in theAcceptabilityChecker.