This repository has been archived by the owner on Nov 3, 2023. It is now read-only.
Enable self_chat to seed messages from tasks in parlai_internal #3852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephenroller
approved these changes
Jul 23, 2021
|
Anytime! 😆 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch description
A fix for enabling self_chat to seed messages from tasks in parlai_internal.
Currently, when we give
--task internal:xxx --seed-messages-from-task truefor self_chat,the
load_openers()function will try to create a dummy task fromparlai.tasks.internal.agentsinstead of
parlai_internal.tasks.xxx.agentsand fails.This is because the first line of
load_openers()parses thebasetaskaccording to:.As a result, when we try to seed from tasks in parlai_internal by prepending
internal:, it will parse the "internal" asbasetask.So, I fixed
load_openers()to pass the task as is when it starts with "internal:".Then the
create_task()will handle it seamlessly as in other circumstances.Testing steps
Other information