This repository has been archived by the owner on Nov 3, 2023. It is now read-only.
[World logging] Fix world logging for dynamic batching #3867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephenroller
approved these changes
Jul 27, 2021
jxmsML
previously requested changes
Jul 27, 2021
tests/test_dynamicbatching.py
Outdated
| dict( | ||
| model_file='zoo:unittest/transformer_generator2/model', | ||
| task='integration_tests:RepeatTeacher:2000', | ||
| world_logs=save_report, |
There was a problem hiding this comment.
nit: world_logs = save_report + '.jsonl'
There was a problem hiding this comment.
Are you sure about that?
There was a problem hiding this comment.
https://github.com/facebookresearch/ParlAI/blob/master/tests/test_eval_model.py#L214-L215
is it here that world_logs and report_filename share the same path?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch description
Episodes were not properly being flushed during world logging since world.acts always returns
[None, None]-- acts are only tracked at the DynamicBatchWorld level. Added a manual check in world logging for a parley to see if the episode is done.Testing steps
Added a test that broke before the change and passes after.