string preprocessing was not performed for 'labels:'

[drevicko]

The current immplementation of tolist (used for 'labels:' and some others) calls tostr() on each label (separated by '|'), but does not store the result.

Patch description
One side effect of the bug: The (currently undocumented) ability to include multiple label fields by separating with a '|' character does not accept the 'PIPE' replacement when a '|' character is required in the label.

Testing steps

> def tolist(txt):
      vals = txt.split('|')
      for v in vals:
          v = tostr(v)
      return vals
> def tostr(txt):
      txt = str(txt)
      txt = txt.replace('\\t', '\t')
      txt = txt.replace('\\n', '\n')
      txt = txt.replace('__PIPE__', '|')
      return txt
> tolist('this is one __PIPE__ two piece | string')
['this is one __PIPE__ two piece ', ' string']
> def tolist(txt):
      vals = txt.split('|')
      for i, v in enumerate(vals):
          v = tostr(v)
          vals[i] = v
      return vals
> tolist('this is one __PIPE__ two piece | string')
['this is one | two piece ', ' string']

Other information

[facebook-github-bot]

Hi @drevicko!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

[stephenroller]

Thanks for your contribution