-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Conversation
f196f19
to
6cec9f2
Compare
542d330
to
6c30d74
Compare
6c30d74
to
27cef31
Compare
if defaults.get(section): | ||
return create_warning(defaults.get(section)) | ||
if self.mode != M_final: | ||
msg = f'Missing {section}: Probably need to be grabbed from paper & added by u (the creator)' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit- u -> you
Hi @liliarose! Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours needs attention. You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Patch description
Moving from internal repo to external. + a couple bug fixes
Also added comments to places that r new (I think I caught most of them, but didn't mark everything that was moved inside/outside the function) + also added a lot of comments :)
Tests
Logs
parlai gmc -mf zoo:blender/blender_90M/model -fts sample_model_cards/blender_90M --mode gen:eval -bs 128 -ne 256
parlai gmc -mf zoo:blender/blender_90M/model -fts sample_model_cards/blender_90M --mode gen:safety_bench --debug True --wrapper blenderbot_90M
(copied the same
args.json
)NOTE THAT THIS WAS DONE IN DEBUGGING MODE FOR FASTER TESTING
parlai gmc -mf zoo:blender/blender_90M/model -fts sample_model_cards/blender_90M --mode gen:sample
parlai gmc -mf zoo:blender/blender_90M/model -fts sample_model_cards/blender_90M --mode gen:sample:safety_bench -ne 1000 --debug True --wrapper blenderbot_90M
parlai gmc -mf zoo:blender/blender_90M/model -fts sample_model_cards/blender_90M
https://gist.github.com/liliarose/f9daeb5cc21a7dc438dbf23f3976797c (too lazy to add the image + safety_benchmark was in debug mode, so the numbers weren't correct)