This repository has been archived by the owner on Nov 3, 2023. It is now read-only.
[crowdsourcing] Forcing mock to shutdown in test cleanup #3889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JackUrb
changed the title
EricMichaelSmith
approved these changes
Aug 2, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch description
Adding a blocking forced shutdown for the Mephisto mock server to the cleanup of Mephisto-based testing. Attempts to ensure that the system doesn't hang indefinitely if a test fails and shutdown is unsuccessful.
Testing steps
Ran crowdsourcing tests locally 50 times. Ended up with a few failures, but none left pytest hanging.