Skip to content
This repository has been archived by the owner on Nov 3, 2023. It is now read-only.

Wizint crowdsourcing #3924

Merged
merged 18 commits into from
Aug 18, 2021
Merged

Wizint crowdsourcing #3924

merged 18 commits into from
Aug 18, 2021

Conversation

mojtaba-komeili
Copy link
Contributor

@mojtaba-komeili mojtaba-komeili commented Aug 9, 2021

Patch description
The crowdsourcing task for the Wizard of Internet project. This is a refactored version of the code we used with the following changes:

  • Code clean ups
  • Removed the hard-coded banned values. Now, they need to be provided as a file with its path in the config file.
  • Removed the code for COVID terms (it will [hopefully] gets outdated for future runs).

Testing steps
Basic QA on running task and checking its functionalities. Some of the screen shots:

Screen Shot 2021-08-11 at 8 32 00 PM
Screen Shot 2021-08-11 at 8 29 57 PM
Screen Shot 2021-08-11 at 8 28 59 PM
Screen Shot 2021-08-11 at 8 28 36 PM
Screen Shot 2021-08-11 at 8 23 09 PM
Screen Shot 2021-08-11 at 8 22 23 PM

@mojtaba-komeili mojtaba-komeili marked this pull request as ready for review August 12, 2021 01:28
Copy link
Contributor

@klshuster klshuster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome stuff, sorry for the late review. i think all my comments are just nits for spell corrections 😄

parlai/crowdsourcing/tasks/wizard_of_internet/README.md Outdated Show resolved Hide resolved
parlai/crowdsourcing/tasks/wizard_of_internet/README.md Outdated Show resolved Hide resolved
parlai/crowdsourcing/tasks/wizard_of_internet/README.md Outdated Show resolved Hide resolved
"""
persona_parts = persona.split('\n')

# It is not from the persona selection ones (personas used during the pilot).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need to include this? i.e. are we supporting personas from the pilot?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually this one is because of the extra explanation that apprentice adds, or the locations that we are adding. Each of those are going be a separate line.

parlai/crowdsourcing/tasks/wizard_of_internet/worlds.py Outdated Show resolved Hide resolved
parlai/crowdsourcing/tasks/wizard_of_internet/worlds.py Outdated Show resolved Hide resolved
parlai/crowdsourcing/tasks/wizard_of_internet/worlds.py Outdated Show resolved Hide resolved
parlai/crowdsourcing/tasks/wizard_of_internet/worlds.py Outdated Show resolved Hide resolved
parlai/crowdsourcing/tasks/wizard_of_internet/worlds.py Outdated Show resolved Hide resolved
@mojtaba-komeili
Copy link
Contributor Author

awesome stuff, sorry for the late review. i think all my comments are just nits for spell corrections 😄

Actually, you did it pretty quickly, given the size and the number of mistakes that I had 😄 .

@mojtaba-komeili mojtaba-komeili merged commit 833b873 into master Aug 18, 2021
@mojtaba-komeili mojtaba-komeili deleted the wizint-crowdsourcing branch August 18, 2021 22:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants