-
Notifications
You must be signed in to change notification settings - Fork 2.1k
[Crowdsourcing] edits for OSS personal knowledge project #3945
Conversation
@@ -63,6 +63,13 @@ def setup_args(cls): | |||
def __init__(self, opt: Dict[str, Any]): | |||
|
|||
super().__init__(opt) | |||
# Validate problem buckets |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
move out of parlai/crowdsourcing/utils/analysis.py
here as it could be that "none_all_good" isn't necessary in problem_buckets
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm, okay, on closer look, I'm fine with moving this check into the subclasses, because the logic that relies upon "none_all_good"
being present is itself in the subclasses
|
||
|
||
def run_task(cfg: DictConfig, task_directory: str): | ||
def run_task(cfg: DictConfig, task_directory: str, world_module=None): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
adding world_module
here so it doesn't have to call the model_chat.worlds
by default but any world_module
as long as it's consistent with cfg.mephisto.blueprint.world_file
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, good to have - thanks for generalizing run_task
, etc.! I have a few nitpicky questions, and in particular, before approving, it might be good to decide where the 'none_all_good'
check should go
parlai/crowdsourcing/tasks/turn_annotations_static/analysis/compile_results.py
Show resolved
Hide resolved
…nderBot 2 (memory part) (#3946) * pk part * del redunda * compile results
Patch description
ContextGenerator
based on thetask_name = 'msc'
ContextGenerator
for any given task:conversation_start_mode
to be either 'hi', or a 'task name' (e.g. 'blended_skill_talk', or 'msc'get_context_generator
inparlai/crowdsourcing/tasks/model_chat/utils.py
will loadContextGenerator
from the<task_name>/agents.py
specified byconversation_start_mode
world_module
as an additional parameter forrun_task
inparlai/crowdsourcing/tasks/model_chat/run.py
parlai/crowdsourcing/tasks/model_chat/worlds.py
, display fancy bot name withself.bot.agent_id
rather than the default agent name from the 'id' field (mostlyTransformerGenerator
)AbstractTurnAnnotationResultsCompiler
toModelChatResultsCompiler
init method.Testing steps
CI
Other information