This repository has been archived by the owner on Nov 3, 2023. It is now read-only.
[BB2] Memory Only Fix #3950
Merged
[BB2] Memory Only Fix #3950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch description
We don't need to classify retrieval when we're dealing with
--knowledge-access-method <memory_only>/<none>. We do not set thequery_generator_vecunless we're in the other three regimes (search_only,classify, orall), and thus we should only generate the queries in these regimes as well.Testing steps
Verified that
parlai i -mf zoo:blenderbot2/blenderbot2_400M/modelworks with--knowledge-access-method memory_only(this would lead to a bug before)