Skip to content
This repository has been archived by the owner on Nov 3, 2023. It is now read-only.

Make the code compatible for fbcode #3964

Merged
merged 5 commits into from
Aug 25, 2021
Merged

Make the code compatible for fbcode #3964

merged 5 commits into from
Aug 25, 2021

Conversation

apravesh
Copy link
Contributor

@apravesh apravesh commented Aug 20, 2021 •
edited
Loading

Make the code compatible for fbcode. We're trying to deploy Blenderbot2 in AI Studio sever_model_zoo and need toadd some exception handling to support that usecase. Since this repo gets synced to fbcode regularly, we can't make persistent changes in fbcode repo only.

@apravesh apravesh requested a review from klshuster August 20, 2021 17:01
klshuster
klshuster previously requested changes Aug 20, 2021
View reviewed changes
Copy link
Contributor

@klshuster klshuster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have any testing steps here to verify that nothing is broken on this end? I think something is broken

parlai/agents/rag/retrievers.py Outdated Show resolved Hide resolved
parlai/core/build_data.py Outdated Show resolved Hide resolved
@apravesh
Copy link
Contributor Author

Do you have any testing steps here to verify that nothing is broken on this end? I think something is broken

I tested now with parlai i -mf zoo:blenderbot2/blenderbot2_3B/model --search-server http://api.search.url and it worked well

@apravesh @stephenroller
Update parlai/agents/rag/retrievers.py
7895ce8 
Co-authored-by: Stephen Roller <roller@fb.com>
stephenroller
stephenroller approved these changes Aug 25, 2021
View reviewed changes
Copy link
Contributor

@stephenroller stephenroller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay maybe in the future we'll write a cleaner HF wrapper but this is good for today.

@apravesh apravesh merged commit 88ed096 into master Aug 25, 2021
@apravesh apravesh deleted the fbcodecompatible branch August 25, 2021 22:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stephenroller stephenroller stephenroller approved these changes

@klshuster klshuster Awaiting requested review from klshuster

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@apravesh @stephenroller @klshuster @facebook-github-bot