This repository was archived by the owner on Nov 3, 2023. It is now read-only.
Disentangled checked_sentence_as_label. #4000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaseweston
reviewed
Sep 9, 2021
There was a problem hiding this comment.
ok that makes sense but then i guess it would be better to be consistent with the wizint ones i made as well, and the new lm one ... bit of a moving target rn (as i'm trying to run an experiment)! can you update and change the wizint ones and the lm too if you want to do this?
added 3 commits
September 9, 2021 06:48
…the next context. Unified mutators across WizWiki and WizInt.
… into wizwiki_mutators
|
I fixed the mutators to not overwrite the original label and hence not copy the modified label to the next inputs. I also unified the mutators across WizWiki and WizInt. The language modeling task can now be achieved by using the mutators add_label_to_input_lm and checked_sentence_as_label together, e.g.:
|
jaseweston
approved these changes
Sep 9, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before it also added the label to the input. Now we have two separate mutators for this behavior: checked_sentence_as_label, add_label_to_input.