This repository has been archived by the owner on Nov 3, 2023. It is now read-only.
[mutators] Prevent name collisions in mutators. #4006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephenroller
force-pushed
the
mutator_collision
branch
from
a994ac3 to
e895e70
Compare
EricMichaelSmith
approved these changes
Sep 14, 2021
jaseweston
approved these changes
Sep 16, 2021
klshuster
approved these changes
Sep 16, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch description
Recently @jaseweston had a spicy bug due to the global namespacing of mutators. This makes this failure case loud.
Testing steps
New CI.