This repository has been archived by the owner on Nov 3, 2023. It is now read-only.
Minor: Print filename when missing in distributed.py #4018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 14, 2021 20:52
...when you have a script that potentially includes file operations (ex when opening a file to load data for a task), this piece of code will eat the filename if it's missing.
stephenroller
approved these changes
Sep 15, 2021
| # Slurm is not installed | ||
| raise RuntimeError('SLURM does not appear to be installed.') | ||
| raise RuntimeError( |
There was a problem hiding this comment.
hm maybe we should only try-catch the subprocess.check_output section. That way we won't eat the FileNotFoundError from way down in the stack
There was a problem hiding this comment.
Don't have enough context to know what that means exactly... seeing as how it's not clear if anyone else has run into this, maybe I'll land this as is for now?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...when you have a script that potentially includes file operations (ex when opening a manually-passed-in json file to load data for a task), this piece of code will eat the filename if it's missing.
** Testing Steps **
Have hit this empirically a few times over the past few days, lol.