This repository has been archived by the owner on Nov 3, 2023. It is now read-only.
[RAG] Fix ReGReT Cuda Issue #4022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mojtaba-komeili
approved these changes
Sep 16, 2021
|
clean install is probably @Rebecca-Qian's issue being discussed internally |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch description
There was a small issue with tensors not being on appropriate devices; this did not show up in the RAG tests since the ReGReT tests are cpu-only (due to memory constraints...)
Testing steps
Tested a command from #3927 manually and confirmed this error 1) showed up before fix, and 2) does not show up after fix