This repository has been archived by the owner on Nov 3, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Crowdsourcing data compiler class for using Mephisto abstractions. #4029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, really great to have this - thanks for pushing the PR out on this! The MockResultsCompiler
in particular will be super valuable. I have a few nits + questions
JackUrb
approved these changes
Sep 20, 2021
The integrations with the Mephisto side make sense to me here, though Eric has a number of good questions and points still |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch description
analysis.py
module in ParlAI crowdsourcing: moved logic fromAbstractDataBrowserResultsCompiler
toAbstractResultsCompiler
.AbstractResultsCompiler
for compiling a dataset from a Mephisto task.MephistoDB
andDataBrowser
.Testing steps
AbstractResultsCompiler
(see PS 2).PS 1. kept
AbstractTurnAnnotationResultsCompiler
for now for not breaking any projects.PS 2. I made a cleaned up version of wizard of internet data compiler that is based on this new
AbstractResultsCompiler
. The next step after landing this would be to add that.