Skip to content
This repository has been archived by the owner on Nov 3, 2023. It is now read-only.

Fixed Some Typos #4100

Merged
merged 3 commits into from
Oct 17, 2021
Merged

Fixed Some Typos #4100

merged 3 commits into from
Oct 17, 2021

Conversation

atharvjairath
Copy link
Contributor

Patch description
Fixed some typing errors and missing word

rertrieving -> retrieving
Removed Extra the
RetrieverType
@facebook-github-bot
Copy link

Hi @atharvjairath!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

1 similar comment
@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

Copy link
Contributor Author

@atharvjairath atharvjairath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the correct word that needs to be there?

Copy link
Contributor

@mojtaba-komeili mojtaba-komeili left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution.

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

Copy link
Contributor

@stephenroller stephenroller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tyvm

@stephenroller stephenroller merged commit 3bdd707 into facebookresearch:main Oct 17, 2021
meganung added a commit that referenced this pull request Oct 25, 2021
* move defaults for fast acute

* add _self_ and move defaults for acute eval

* udpated config overrides in test

* move defaults for model chat and update test

* move defaults for model image chat and update test

* add hydra_configs to config path and update test

* move defaults and add self for qa data collection task

* move defaults to yaml, add self, and update tests

* onboarding qualification arg

* Fixed Some Typos (#4100)

* Add onboarding to crowdsourcing tests (#4096)

* add support for registering and onboarding agent

* add a value for onboarding qualification instead of null to test

* add parameter assume_onboarding and fix spelling

* move defaults for fast acute

* add _self_ and move defaults for acute eval

* udpated config overrides in test

* move defaults for model chat and update test

* move defaults for model image chat and update test

* add hydra_configs to config path and update test

* move defaults and add self for qa data collection task

* move defaults to yaml, add self, and update tests

* onboarding qualification arg

* rebase

* rebase more edits and cleanup

* linting

* placeholder to remove unused import error

* move defaults for tasks in crowdsourcing projects

* point to new mephisto release for circle ci

Co-authored-by: Atharv jairath <54663702+atharvjairath@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants