This repository has been archived by the owner on Nov 3, 2023. It is now read-only.
woi: filter knowledge #4114
Merged
woi: filter knowledge #4114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return out_episodes | ||
|
|
||
|
|
||
| @register_mutator("woi_filter_selected_knowledge_in_retrieved_docs") |
There was a problem hiding this comment.
I don't see any reason for having this teacher. Given how the task teacher add these fields here. The overlap must exist between the selected sentences and the retrieved sentences.
There was a problem hiding this comment.
(It's a mutator, not a teacher). It was to debug check that it is true, because of the problems Leo reported.. it might be useful for other tasks in the future with knowledge..
mojtaba-komeili
approved these changes
Oct 27, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.