This repository has been archived by the owner on Nov 3, 2023. It is now read-only.
WoI: chunk docs #4122
Merged
WoI: chunk docs #4122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| def message_mutation(self, message: Message) -> Message: | ||
|
|
||
| new_message = message.copy() | ||
| if '__retrieved-docs__' not in message: |
There was a problem hiding this comment.
I suggest replacing the hard-coded key values with the names from here
There was a problem hiding this comment.
nit: also this if condition could go before the deep copy (slight speed up).
| new_message = message.copy() | ||
| if '__retrieved-docs__' not in message: | ||
| return message | ||
| del new_message['__retrieved-docs__'] |
There was a problem hiding this comment.
Is this del necessary given that it gets set later in line 726?
There was a problem hiding this comment.
you either have to do this or a force_set on the message I think..
mojtaba-komeili
approved these changes
Oct 28, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.