Skip to content
This repository has been archived by the owner on Nov 3, 2023. It is now read-only.

woi: doc chunker doesn't split gold checked sentences #4125

Merged
merged 3 commits into from
Oct 29, 2021
Merged

woi: doc chunker doesn't split gold checked sentences #4125

merged 3 commits into from
Oct 29, 2021

Conversation

jaseweston
Copy link
Contributor

No description provided.

klshuster
klshuster approved these changes Oct 29, 2021
View reviewed changes
Copy link
Contributor

@klshuster klshuster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, only minor consideration is that we're looping over checked sentences each time, perhaps unnecessarily, but those lists are never more than a few items long so it's essentially constant

@jaseweston jaseweston merged commit a8d1dc3 into main Oct 29, 2021
@jaseweston jaseweston deleted the k2r3 branch October 29, 2021 16:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@klshuster klshuster klshuster approved these changes

@mojtaba-komeili mojtaba-komeili Awaiting requested review from mojtaba-komeili

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jaseweston @klshuster @facebook-github-bot