Skip to content
This repository has been archived by the owner on Nov 3, 2023. It is now read-only.

dicts to messasges #4144

Merged
merged 2 commits into from
Nov 6, 2021
Merged

dicts to messasges #4144

merged 2 commits into from
Nov 6, 2021

Conversation

mojtaba-komeili
Copy link
Contributor

Patch description
Changed the Wizard of Wikipedia examples from dict to Message. Running WoW with parlai dd used to show the following warning about the teacher examples being dict instead of Message.

Screen Shot 2021-11-05 at 1 47 13 PM

Testing steps

  1. The existing teacher tests.
  2. Checking that warning doesn't appear anymore.

klshuster
klshuster approved these changes Nov 5, 2021
View reviewed changes
Copy link
Contributor

@klshuster klshuster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for this!

@mojtaba-komeili mojtaba-komeili merged commit a6f368c into main Nov 6, 2021
@mojtaba-komeili mojtaba-komeili deleted the wow-msg branch November 6, 2021 01:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@klshuster klshuster klshuster approved these changes

@stephenroller stephenroller Awaiting requested review from stephenroller

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mojtaba-komeili @klshuster @facebook-github-bot