This repository has been archived by the owner on Nov 3, 2023. It is now read-only.
[BB2] Handle no-memories in memory_only
case
#4156
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch description
When training with
--knowledge-access-method memory_only
, we send every example to access the long-term memory. If some examples within that batch do not have anymemory
vectors, the current access errors out.This fix bars access to the
memory_vec
to be only those examples with tokenized memories; other examples are handled by adding "fake" memories, as is done in the--knowledge-access-method classify
scenario.Testing steps
Ran
test_bb2.py
locally: