This repository was archived by the owner on Nov 3, 2023. It is now read-only.
[TOD] Core conversation structure, serialization, const tokens #4174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moyapchen
requested review from
stephenroller,
EricMichaelSmith,
chinnadhurai and
skiingpacman
moyapchen
force-pushed
the
simpler_tod_1_core_only
branch
from
e365e48 to
1480def
Compare
moyapchen
commented
Nov 16, 2021
| """ | ||
|
|
||
| # Variables set by those using this class | ||
| delex: bool = False # Set to true and this class will handle delexicalizing call + response utterances based on API calls and responses exposed to this class. |
There was a problem hiding this comment.
Oof, need to find a linter that will wrap comments hmm...
Docformatter also fails to format the other comments inside of """'s. Playing around with all of its different args, it seems to not catch these, or the ones higher up. (CC: @stephenroller )
…iff in stack, but lost from this one
This was referenced Nov 16, 2021
stephenroller
approved these changes
Nov 20, 2021
EricMichaelSmith
approved these changes
Nov 23, 2021
|
Thanks for the reviews! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Core components. How they are used + testing gets done later in the stack.