This repository has been archived by the owner on Nov 3, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch description
Previously, if we errored out attempting to read a
.csv
file, we switched to reading passages and splitting by\t
manually. However, we were still referencing an old variable from the prior loop, which references an old row. I've updated to point to the new variable.Testing steps
I discovered this because someone pointed out that their retriever was retrieving the same document for every turn. I looked at the logs and saw that the indexing for 5k documents was taking over 5 minutes; this is way too slow, and usually means that the passage embeddings are too close to eachother. After reproducing the error locally, the passages are correctly loaded and indexing takes around 2 seconds.
Relying on CI for the rest.