This repository was archived by the owner on Nov 3, 2023. It is now read-only.
[RAG] Handle Self Chat #4207
Merged
[RAG] Handle Self Chat #4207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
btw, I've notice the KeyError when running interactive (in human-model chat, not selfchat) before, but unable to reproduce. |
indeed it's a related error |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch description
Update RAG to ensure it handles self-chat. This primarily involves ensuring that the
query_keyis in the observation before accessing it.Addresses #4202
Testing steps
Added test, confirmed it failed pre-fix and works post-fix