This repository has been archived by the owner on Nov 3, 2023. It is now read-only.
Save conversations check for parent directory #4218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parlai/utils/conversations.py
Outdated
Comment on lines
281
to
286
| parent_dir = os.path.dirname(datapath) | ||
| if os.path.exists(parent_dir) and os.path.isdir(parent_dir): | ||
| return | ||
| logging.info(f'Parent directory ({parent_dir}) did not exist and was created.') | ||
| os.makedirs(parent_dir) | ||
|
|
There was a problem hiding this comment.
needs to be migrated to pathmanager, thx
|
@stephenroller switched to Also, what's up with jslint? It keeps breaking for any PR today. |
stephenroller
approved these changes
Dec 2, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch description
Saving the conversation log was crashing if the parent directory of the provided path to save the file didn't exist. This patch checks for the dir that is going to contain the output file. It creates the parent directories if they do not exist.
Testing steps
Had a script that crashed while trying to save the data. The problem was solved after adding this code. It created the parent directory and saved the data.