This repository has been archived by the owner on Nov 3, 2023. It is now read-only.
[BlenderBot2] A hybrid mode (skip search when needed) #4221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jxmsML
changed the title
| @@ -181,7 +181,7 @@ def __init__(self, opt: Opt): | |||
| ) | |||
| assert isinstance(base_agent, TorchAgent) | |||
| self.agents = [base_agent] | |||
| bsz = max(opt.get('batchsize', 1), opt.get('eval_batchsize', 1)) | |||
| bsz = max(opt.get('batchsize') or 1, opt.get('eval_batchsize') or 1) | |||
There was a problem hiding this comment.
Oddly, I was getting this error when trying this agent. This change was a solution to avoid it.
There was a problem hiding this comment.
hmm interesting, I thought anything return from opt.get(XXX, 1) would never be None
There was a problem hiding this comment.
it can be None if the arg is in opt but no value is given
jxmsML
commented
Dec 1, 2021
| @@ -894,6 +914,13 @@ def build_model(self) -> Union[BlenderBot2FidModel, T5BlenderBot2FidModel]: | |||
| return model | |||
|
|
|||
|
|
|||
| class BlenderBot2SearchQueryFiDAgent(BlenderBot2FidAgent): | |||
klshuster
approved these changes
Dec 1, 2021
jxmsML
commented
Dec 2, 2021
| yield message, episode_started | ||
|
|
||
|
|
||
| class WizardDialogGoldKnowledgeTeacher(WizardDialogTeacher): | ||
| def __init__(self, opt, shared=None): | ||
| super().__init__(opt, shared=shared) | ||
| self.id = 'WizardDialogGoldKnowledgeTeacher' |
There was a problem hiding this comment.
ah thanks for adding this, otherwise the train_model always flags this red warning ;)
added 2 commits
December 2, 2021 12:20
|
teacher tests seem to pass now! thanks god will merge it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch description
Pass a new batch field
skip_searchto classify_retrieval: to skip search if that field is true.This can be useful for example, when gold knowledge is prepended to the text.
Testing steps
Other information