This repository has been archived by the owner on Nov 3, 2023. It is now read-only.
See if I can fix crowdsourcing jslint pre-commit hook error #4223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not sure why this is suddenly causing the jslint to fail when it didn't prior, but seems like a reasonable thing to fix. Copypasting from `parlai/mturk/package.json` file of https://github.com/facebookresearch/ParlAI/pull/3362/files
moyapchen
changed the title
|
Hmm @moyapchen what's the jslint pre-commit hook error that you see without this change? If it's fine with @JackUrb it's fine with me |
|
@EricMichaelSmith See things in https://github.com/facebookresearch/ParlAI/actions/workflows/lint.yml (A lot of it's my diffs, but if you scroll through, seems like other folks are hitting it too) |
|
Seems alright to me as well, unsure what the sudden change was, but if this resolves it then LGTM |
EricMichaelSmith
approved these changes
Dec 1, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure why this is suddenly causing the jslint to fail when it didn't prior, but seems like a reasonable thing to fix.
Copypasting from
parlai/mturk/package.jsonfile of https://github.com/facebookresearch/ParlAI/pull/3362/filesUsing this change to see if it fixes the stuff. Indeed, the jslint test no longer fails (though there's one in cleaninstall that I'm currently yak shaving...)