Skip to content
This repository has been archived by the owner on Nov 3, 2023. It is now read-only.

[SaFeRDialogues] dataset and model release #4229

Merged
merged 8 commits into from
Dec 9, 2021
Merged

Conversation

meganung
Copy link
Contributor

@meganung meganung commented Dec 6, 2021

Patch description
adding the SaFeRDialogues dataset -t saferdialogues and model -mf zoo:saferdialogues/model

Updated the task list and model zoo list. Added the license in the task folder.

Testing steps
pytest parlai/tasks/saferdialogues/test.py passes!
parlai em -t saferdialogues -mf zoo:saferdialogues/model

@meganung meganung requested a review from jxmsML December 6, 2021 15:54
@meganung meganung marked this pull request as draft December 6, 2021 15:55
@meganung meganung marked this pull request as ready for review December 6, 2021 18:49
Copy link
Contributor

@jxmsML jxmsML left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!! Thanks for the OSS efforts! some minor comments

@meganung meganung requested a review from jxmsML December 9, 2021 14:49
Copy link
Contributor

@stephenroller stephenroller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very complete to me.

@meganung meganung merged commit 89e8c32 into main Dec 9, 2021
@meganung meganung deleted the saferdialogues_dataset branch December 9, 2021 18:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants