This repository has been archived by the owner on Nov 3, 2023. It is now read-only.
[TOD][Teachers] Add TOD Teachers + base Parser agent #4233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests in next diff in stack.
moyapchen
commented
Dec 13, 2021
| from parlai.core.params import ParlaiParser | ||
| from parlai.core.opt import Opt | ||
| from parlai.core.teachers import DialogTeacher | ||
| from parlai.utils.distributed import is_distributed, get_rank, num_workers |
There was a problem hiding this comment.
Ignore these lint failures - they are used in the next change in this stack.
skiingpacman
approved these changes
Dec 13, 2021
…to simpler_tod_2a_teachers_only
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking up #4176 into two diffs in the hope that makes these easier to review.
This focuses on the teachers used to train models. Idea here is straightforward - Implement the Parser first, then use multiple inheritance to define the Teachers.
This diff does 3 things:
Helper agents + tests for teachers + agents in next diff in stack.
NOTE: Diff commit history looks a little weird here since I accidentally merged something above into this stack, the reverted it. >.> (I did check this diff before merging and it's fine.)