Skip to content
This repository has been archived by the owner on Nov 3, 2023. It is now read-only.

Fix Crowdsourcing Tests after mephisto hydra upgrade #4236

Merged
merged 5 commits into from
Dec 13, 2021

Conversation

meganung
Copy link
Contributor

@meganung meganung commented Dec 9, 2021

Patch description
After hydra upgrade, blueprints are specified in yaml files so instead of specifying the blueprint, we point to the right yaml file (which specifies the blueprint) and remove any overrides that aren’t necessary (e.g. those that are defined in the yaml file or defaults in the blueprint). Some overrides are still there since they do indeed override values in the yaml file or the default ones in the blueprint.

Testing steps
pytest tests/crowdsourcing/tasks

@meganung meganung marked this pull request as ready for review December 10, 2021 00:16
Copy link
Contributor

@EricMichaelSmith EricMichaelSmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh wow - this is fantastic! This is gonna make it so much easier for us to make new tests or change existing ones :) Thanks so much for making this change!

@meganung meganung merged commit 9a0cd72 into main Dec 13, 2021
@meganung meganung deleted the meph-hydra-update-fix-tests branch December 13, 2021 16:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants