Skip to content
This repository has been archived by the owner on Nov 3, 2023. It is now read-only.

[LIGHT] AIMOY #4239

Merged
merged 6 commits into from
Dec 14, 2021
Merged

[LIGHT] AIMOY #4239

merged 6 commits into from
Dec 14, 2021

Conversation

klshuster
Copy link
Contributor

Patch description
Code and models. Mostly looking for comments on the respective READMEs.

Testing steps
Added CI, with both local tests for pre-trained models and CI tests for code functionality; both work as expected.

CI Tests:
Screen Shot 2021-12-09 at 5 49 47 PM

W/ Pre-trained Models:

Screen Shot 2021-12-09 at 5 49 55 PM

@mojtaba-komeili
Copy link
Contributor

WizInt again!?

Copy link
Contributor

@JackUrb JackUrb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow this is a lot of agents. I found the documentation really thorough on how each of them can be extended and used in other contexts in the future, so this looks really good to me!

As a nitty aside, it seems autoformat.sh really wants to make a lot of changes, could be worthwhile to include, but is likely just dropping spaces out or something.


### 1. Train a classifier or ranker model.

The first step is to train a model -- e.g. `transformer/biencoder`, `transformer/polyencoder`, or 'transformer/classifier` -- on a desired classification or ranking task.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'transformer/classifier` -> `transformer/classifier`

Copy link
Contributor

@stephenroller stephenroller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aimoy, matey

@klshuster klshuster merged commit 7db03e9 into main Dec 14, 2021
@klshuster klshuster deleted the amimeoryou_oss branch December 14, 2021 05:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants