This repository has been archived by the owner on Nov 3, 2023. It is now read-only.
[BlenderBot2] add model.module to make BB2 DDP compatible #4259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klshuster
suggested changes
Dec 17, 2021
| @@ -800,7 +800,10 @@ def _set_batch_skip_search(self, valid_exs: List[Message], batch: Batch) -> Batc | |||
|
|
|||
| def eval_step(self, batch): | |||
| output = super().eval_step(batch) | |||
| if output is None or not hasattr(self.model, 'retriever'): | |||
| model = self.model | |||
| if isinstance(self.model, torch.nn.parallel.DistributedDataParallel): | |||
There was a problem hiding this comment.
actually, this is what self.model_api is meant to accomplish, if you can just switch to that
klshuster
suggested changes
Dec 20, 2021
Comment on lines
803
to
806
| model = self.model_api | ||
| if isinstance(model, torch.nn.parallel.DistributedDataParallel): | ||
| model = model.module | ||
| if output is None or not hasattr(model, 'retriever'): |
There was a problem hiding this comment.
sorry, I might not have been clear enough: model_api already takes care of this check
Suggested change
| model = self.model_api | |
| if isinstance(model, torch.nn.parallel.DistributedDataParallel): | |
| model = model.module | |
| if output is None or not hasattr(model, 'retriever'): | |
| if output is None or not hasattr(self.model_api, 'retriever'): |
This is the only change required
There was a problem hiding this comment.
ah didn't know that! thanks for the pointer
klshuster
approved these changes
Dec 21, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch description
Change model -> model.module in DistributedDataParallel setting in
Testing steps
Other information