Skip to content
This repository has been archived by the owner on Nov 3, 2023. It is now read-only.

[BB2] loading BB2 without skip-search-key flag. #4289

Merged
merged 1 commit into from
Jan 6, 2022

Conversation

mojtaba-komeili
Copy link
Contributor

Patch description
Trying to load a BB2 model, because the new flag is not in the main opt, it was crashing (dict key error).

Screen Shot 2022-01-06 at 11 47 36 AM

Using get from the opt to avoid the crash.

Copy link
Contributor

@jxmsML jxmsML left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the fix

@mojtaba-komeili mojtaba-komeili merged commit 2698017 into main Jan 6, 2022
@mojtaba-komeili mojtaba-komeili deleted the bb2-skip-search-opt branch January 6, 2022 19:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants