This repository has been archived by the owner on Nov 3, 2023. It is now read-only.
Trainstats Clobber Bug #4386
Merged
Trainstats Clobber Bug #4386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch description
TrainLoop._save_train_statsis currently called in two places:TrainLoop.trainandTrainLoop.save_model.TrainLoop.save_modelreturns early if it's not the primary worker, butTrainLoop.traindoes not. To make sure the.trainstatsfile isn't written to from multiple workers at once, this PR adds a return-early check directly inTrainLoop._save_train_stats.Testing steps
Circle CI