This repository has been archived by the owner on Nov 3, 2023. It is now read-only.
use should_shuffle instead of is_training to determine whether to ran… #4425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…domly sample from worlds
stephenroller
approved these changes
Mar 16, 2022
|
LGTM. One question (more a clarification) what's being addressed by "added warning about using datatype that doesn't shuffle with multitask weights"? It's not clear to me what this is saying? That "weighting" of tasks isn't respected or something else? |
skiingpacman
approved these changes
Mar 16, 2022
Yep! warning that the weighing of tasks is not respected |
juderoque
deleted the
3662-multiworld-behaves-nondeterministically-on-ordered
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…domly sample from worlds
Patch description
Addresses #3662 by using should_shuffle instead of is_training to determing whether to randomly sample between worlds or to use the round-robin world selection.
Testing steps
pytest tests/test_multiworld.py(test_with_ordered)Other information
When should shuffle is False, multitask weights are effectively ignored. We warn the user if they choose a datatype that doesn't shuffle and also specify multitask weights.