This repository has been archived by the owner on Nov 3, 2023. It is now read-only.
[empathetic dialogues] Whitespace changes #4435
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch description
We had a small bug with one label not being in the label candidates causing a crash in the new ED teacher (#4405). Upon inspection, it was because of a trailing whitespace in the candidate but not the text. Upon further inspection, I found the data had lots of trailing whitespaces. This normalizes that.
Testing steps
CI and
parlai em -t empathetic_dialogues -m repeat_query/repeat_label
Before #4405:
After #4405:
(Crashes)
With this PR: