Skip to content
This repository has been archived by the owner on Nov 3, 2023. It is now read-only.

[empathetic dialogues] Whitespace changes #4435

Merged
merged 1 commit into from
Mar 22, 2022
Merged

[empathetic dialogues] Whitespace changes #4435

merged 1 commit into from
Mar 22, 2022

Conversation

stephenroller
Copy link
Contributor

Patch description
We had a small bug with one label not being in the label candidates causing a crash in the new ED teacher (#4405). Upon inspection, it was because of a trailing whitespace in the candidate but not the text. Upon further inspection, I found the data had lots of trailing whitespaces. This normalizes that.

Testing steps

CI and parlai em -t empathetic_dialogues -m repeat_query/repeat_label

Before #4405:

$ parlai em -t empathetic_dialogues -m repeat_query
    accuracy   bleu-4  exs    f1
    .0001743 .0007299 5738 .1060

$ parlai em -t empathetic_dialogues -m repeat_label
    accuracy  bleu-4  exs    f1
           1   .9645 5738 .9998

After #4405:
(Crashes)

With this PR:

$ parlai em -t empathetic_dialogues -m repeat_query
    accuracy   bleu-4  exs    f1
    .0001743 .0007299 5738 .1060

$ parlai em -t empathetic_dialogues -m repeat_label
    accuracy  bleu-4  exs    f1
           1   .9645 5738 .9998

@stephenroller stephenroller merged commit 6147606 into main Mar 22, 2022
@stephenroller stephenroller deleted the fixed branch March 22, 2022 19:39
Copy link
Contributor

@EricMichaelSmith EricMichaelSmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, would not have expected that, but great find =/ Thanks for the fix!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants