This repository has been archived by the owner on Nov 3, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch description
set_decoding_method
for flexibility.Seems like for the SeeKeR models, in order to use the --inference-strategies one must set decoding through:
agent_clone.opt['inference'] = XXXX for agent_clone in self.dialogue_agent_clones
instead of
self.opt['drm_inference'] = XXXX
, sinceself.opt['drm_inference']
is only used during initialization.batch_reply
as the parameter ofget_observations_for_reranker
for flexibility:For the SeeKeR case, the knowledge sentence can only be accessed thru
batch_reply[i].knowledge_response
. Addingbatch_reply
to the functionget_observations_for_reranker
would be useful for make the context + knowledge_ sentence as theobservation['full_text']
Testing steps
Other information