This repository has been archived by the owner on Nov 3, 2023. It is now read-only.
[PACER] Adding flexibility + removing padding idx before v2t #4488
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch description
'classifier' is in shared
, this is for the SeeKeR case, wheredialogue_agent = model_class(opt, knowledge_agent.share())
but knowledge_agent.share() doesn't have classifier attributedef get_target_character(self):
that returns the target label the reranker tries to optimize for.self.agent_v2t(self.context)
, otherwise during batch generation one might run into this kind of errorKeyError, '__null__' not found in self.dict
int(pred['text'] == self.character) - 1
replaced withpred['text_candidates'].index(self.character)
in case the predictor is a multi-class.Testing steps
Other information