Skip to content
This repository has been archived by the owner on Nov 3, 2023. It is now read-only.

Delete BST aux teachers #4513

Merged
merged 2 commits into from
Apr 26, 2022
Merged

Delete BST aux teachers #4513

merged 2 commits into from
Apr 26, 2022

Conversation

stephenroller
Copy link
Contributor

Patch description
After discussion as a group, we've decided to retire these teachers instead of updating them.

Testing steps
CI

EricMichaelSmith
EricMichaelSmith approved these changes Apr 26, 2022
View reviewed changes
Copy link
Contributor

@EricMichaelSmith EricMichaelSmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, assuming that this is all of the references to the PersonaTopicifier teachers, and conditional on CI checks passing of course :P I see some lint errors for unused imports, for instance

@stephenroller stephenroller merged commit 857b5de into main Apr 26, 2022
@stephenroller stephenroller deleted the delwowteacher branch April 26, 2022 18:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@EricMichaelSmith EricMichaelSmith EricMichaelSmith approved these changes

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stephenroller @EricMichaelSmith @facebook-github-bot