Skip to content
This repository has been archived by the owner on Nov 3, 2023. It is now read-only.

[tasks/huggingface] Way to add to message but not "text" #4516

Merged
merged 1 commit into from
Apr 27, 2022

Conversation

moyapchen
Copy link
Contributor

I want to be able to add my own mutators to grab information from other fields out of a huggingface dataset. Since I don't want it to show up in the text itself, I do it in a new attribute.

I also delete some code that was written at some point but isn't used anywhere while I'm here.

Test Plan:
Run parlai dd -t with a new dataset that I'm working on that uses this.

Also run parlai dd -t glue; parlai dd -t superglue to validate that I don't break anything that already exists. (Former dies, but it's cause of a dataset issues on the HF side where the size of the datasets have changed, so not worrying about it)

I want to be able to add my own mutators to grab information from other fields out of a huggingface dataset. Since I don't want it to show up in the text itself, I do it in a new attribute.

I also delete some code that was written at some point but isn't used anywhere while I'm here.

Test Plan:
Run `parlai dd -t` with a new dataset that I'm working on that uses this.

Also run `parlai dd -t glue; parlai dd -t superglue` to validate that I don't break anything that already exists. (Former dies, but it's cause of a dataset issues on the HF side where the size of the datasets have changed, so not worrying about it)
Copy link
Contributor

@meganung meganung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm !!

@moyapchen moyapchen merged commit 4f7e4b6 into main Apr 27, 2022
@moyapchen moyapchen deleted the mpchen/hf_fields_to_save branch April 27, 2022 14:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants