Skip to content
This repository has been archived by the owner on Nov 3, 2023. It is now read-only.

remove package-lock file #4532

Merged
merged 3 commits into from
May 10, 2022
Merged

remove package-lock file #4532

merged 3 commits into from
May 10, 2022

Conversation

meganung
Copy link
Contributor

@meganung meganung commented May 8, 2022

Remove unnecessary package-lock file- it causes a bunch of vulnerability warnings and also should be automatically created from building the package.

EricMichaelSmith
EricMichaelSmith approved these changes May 9, 2022
View reviewed changes
Copy link
Contributor

@EricMichaelSmith EricMichaelSmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oof, yes, agreed

@JackUrb
Copy link
Contributor

JackUrb commented May 9, 2022

You'll want to add these to .gitignore or they may inevitably be re-added in the future.

stephenroller
stephenroller approved these changes May 9, 2022
View reviewed changes
Copy link
Contributor

@stephenroller stephenroller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tyyy

@meganung meganung merged commit 5f13a2d into main May 10, 2022
@meganung meganung deleted the remove-package-lock branch May 10, 2022 15:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@EricMichaelSmith EricMichaelSmith EricMichaelSmith approved these changes

@stephenroller stephenroller stephenroller approved these changes

@JackUrb JackUrb Awaiting requested review from JackUrb

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@meganung @JackUrb @stephenroller @EricMichaelSmith @facebook-github-bot