This repository has been archived by the owner on Nov 3, 2023. It is now read-only.
cache api calls and responses on setup #4565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moyapchen
suggested changes
Jun 1, 2022
moyapchen
reviewed
Jun 1, 2022
76.7 seconds on first pytest run with no presaved cache files |
|
..and which datatype is that? |
unit tests cover all three looks like |
|
Ahhh brainfart there; eyes somehow skipped "pytest" there in "first pytest run" |
moyapchen
reviewed
Jun 1, 2022
added 2 commits
June 1, 2022 11:00
kushalarora
pushed a commit
that referenced
this pull request
Jun 15, 2022
* cache api calls and responses on setup * use PathManager instead of os and json instead of pickle * fix json.load and file open * fix typo Co-authored-by: Martin Corredor <mcorredor@devfair0237.h2.fair>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch description
Cache api calls to responses dictionary on setup for multiwoz_v22
Testing steps
Unit tests all pass
Train dataset output validation:
Original output on left, new output on right
Test dataset output:
Valid dataset output:
Other information
Unit tests run in 1/4 the time with caching vs without
~63 seconds vs ~257 seconds