Skip to content
This repository has been archived by the owner on Nov 3, 2023. It is now read-only.

feat: add exception handling to _unzip method in build_data.py to con… #4572

Merged
merged 2 commits into from
Jun 7, 2022

Conversation

chiehminwei
Copy link
Contributor

@chiehminwei chiehminwei commented Jun 6, 2022

Patch description
This patch fixe issue #4567
When _unzip fails to unzip a certain file, execution continues for other files without stopping the whole flow.

…tinue execution even when some files fail to extract
Copy link
Contributor

@mojtaba-komeili mojtaba-komeili left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address the lint errors.

@chiehminwei chiehminwei requested a review from stephenroller June 6, 2022 17:34
Copy link
Contributor

@mojtaba-komeili mojtaba-komeili left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chiehminwei chiehminwei merged commit 023611d into main Jun 7, 2022
@chiehminwei chiehminwei deleted the fix-unzip-macos branch June 7, 2022 17:36
pearlli98 pushed a commit that referenced this pull request Jun 9, 2022
#4572)

* feat: add exception handling to _unzip method in build_data.py to continue execution even when some files fail to extract

* fix lint error
kushalarora pushed a commit that referenced this pull request Jun 15, 2022
#4572)

* feat: add exception handling to _unzip method in build_data.py to continue execution even when some files fail to extract

* fix lint error
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants