This repository has been archived by the owner on Nov 3, 2023. It is now read-only.
Pearlli model chat analysis refactor #4577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 12 commits
June 6, 2022 14:54
This reverts commit d2a0e7a.
There was a problem hiding this comment.
Yeah this looks great! Ha, you handled these edge cases and got the tests to pass much more smoothly than what I was worried about :) I have a few comments but nothing too major, just some cleanups
@JackUrb @pringshia This is working towards the goal of eventually getting all of ParlAI's tasks onto DataBrowser and away from a brittle loading of raw outputs from disk
tests/crowdsourcing/tasks/model_chat/test_model_chat_analysis.py
Outdated
Show resolved
Hide resolved
EricMichaelSmith
approved these changes
Jun 8, 2022
kushalarora
pushed a commit
that referenced
this pull request
Jun 15, 2022
* change analysis script to use databrowernstead of lading from disk * add model chat data for testing purposes * Revert "add model chat data for testing purposes" This reverts commit d2a0e7a. * get rid of re and json imports * remove start-date flag and fix lint error * add dummy class to mocks DataBrowser output * update test results * add results-folders flag * add results-folders flag * remove check for results-folders * remove results-folders flag * update test to run without results-folders * update readme * move --hit-block-list to subclass, add comments, remove unnecessary initialization * add protobuf to requirement for tensorboard 2.9.1 * change tensorboard to 2.9.0 Co-authored-by: Pearl Li <pearlli@devfair0420.h2.fair>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch description
ModelChatResultsCompilerclass such that itsget_task_data()mimics databrowser outputs.results-foldersflag fromAbstractTurnAnnotationResultsCompilerand added to the subclasses that still need it (ModelChatResultsCompilerandTurnAnnotationsStaticResultsCompiler)Testing steps
pytest ~/ParlAI/tests/crowdsourcing/tasks/model_chat/test_model_chat_analysis.py