-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Conversation
We removed the |
Not sure what do you mean. Main is failing. You can also look at previous runs in this commit thread on latest main, they are all failing. |
i think those are spurious errors; it seems that #4590 had passing tests when it was landed |
I'm not sure how it passed, but both main and my commits where are failing systematically with the same error. I have re-runned them several times, always same error here and in #4589 |
Will create a PR with text changes only |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approving given everything passes. Thanks!
Huh, still failed in mainline. Is it possible that some other changes are required in circleci config? |
Patch description
Adding/fixing comments. Fixing main to make it pass tests.
Testing steps
Other information