This repository has been archived by the owner on Nov 3, 2023. It is now read-only.
Fix downloading of TOD models #4647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Definitions inside the models were usin the Bart R3F versions which we never actually open sourced. Regular old BART is pretty much the same though. Test Plan: On a completely fresh git clone of ParlAI only, run ``` parlai dm -mf zoo:tod/tod_base_no_api/model --skip-generation false --task google_sgd_simulation_splits:OutDomainSystemTeacher -dt valid ``` and ``` parlai dm -mf zoo:tod/tod_base_yes_api/model --skip-generation false --task google_sgd_simulation_splits:OutDomainSystemTeacher -dt valid --api-schemas true ``` Validate models load properly and don't have the `parlai_fb` thing
stephenroller
approved these changes
Jul 7, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing #4627 Definitions inside the models were using the Bart R3F versions which we never actually open sourced. Regular old BART is pretty much the same though.
Test Plan:
On a completely fresh git clone of ParlAI only, run
and
Validate models load properly and don't crash on the
parlai_fbthing