Skip to content
This repository has been archived by the owner on Nov 3, 2023. It is now read-only.

Friends teacher include speaker in context #4678

Merged
merged 2 commits into from
Jul 25, 2022
Merged

Conversation

chiehminwei
Copy link
Contributor

Patch description

  • Add a command line option --include-speaker-in-context (defaults to True) in the teacher to include speaker in the context, instead of in the label.
Before
    text: A: Hello!
    label: B: Hi!

After
    text: A: Hello!
          B:
    label: Hi!
  • Add a command line option --silence-token-dropout (defaults to 1) that determines the dropout rate for including __SILENCE__ token in the generated training examples.

Testing steps
pytest test.py

Data Display

parlai dd --task friends

image

Copy link
Contributor

@mojtaba-komeili mojtaba-komeili left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

@chiehminwei chiehminwei merged commit 6c02980 into main Jul 25, 2022
@chiehminwei chiehminwei deleted the friends_teacher_context branch July 25, 2022 22:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants